Issue 9586012: Some fixes split off from https://chromiumcodereview.appspot.com/9570064/ to try and make the omnib…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9586012: Some fixes split off from https://chromiumcodereview.appspot.com/9570064/ to try and make the omnib… (Closed)

Created:
8 years, 9 months ago by Peter Kasting

Modified:
8 years, 1 month ago

Reviewers:
mrossetti, Mark P

CC:
chromium-reviews, brettw-cc_chromium.org, James Su, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Some fixes split off from https://chromiumcodereview.appspot.com/9570064/ to try and make the omnibox_view_browsertest.cc tests less flaky and make it possible to use the HQP in them. BUG=none TEST=none TBR=mrossetti Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124681

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -54 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_browsertest.cc	View	2 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View	11 chunks	+53 lines, -44 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Mike, FYI, I'm landing this change now that you previously reviewed, in hopes of making ...

8 years, 9 months ago (2012-03-02 17:55:38 UTC) #1

mrossetti

LGTM https://chromiumcodereview.appspot.com/9586012/diff/1/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/9586012/diff/1/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#newcode1010 chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1010: #if 0 Note that this should be okay ...

8 years, 9 months ago (2012-03-02 18:11:46 UTC) #2

Mark P

8 years, 1 month ago (2012-11-07 21:23:35 UTC) #3

https://chromiumcodereview.appspot.com/9586012/diff/1/chrome/browser/ui/omnib...
File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right):

https://chromiumcodereview.appspot.com/9586012/diff/1/chrome/browser/ui/omnib...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1010: #if 0
On 2012/03/02 18:11:46, mrossetti wrote:
> Note that this should be okay to re-enable now. I'll submit this as the dregs
of
> my earlier CL.

You seem to have forgotten to reenable this.

Expand Messages | Collapse Messages