Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 9586009: Move TabContentsViewGtk's delegate to content\public\browser. Also name it a delegate instead of a … (Closed)

Created:
8 years, 9 months ago by jam
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move TabContentsViewGtk's delegate to content\public\browser. Also name it a delegate instead of a wrapper to match what Mac (and Win soon) call theirs. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124695

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -338 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.cc View 1 chunk +0 lines, -156 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_gtk_delegate.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_gtk_delegate.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +10 lines, -3 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.cc View 7 chunks +15 lines, -15 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_wrapper_gtk.h View 1 chunk +0 lines, -57 lines 0 comments Download
M content/content_browser.gypi View 1 3 chunks +7 lines, -1 line 0 comments Download
A + content/public/browser/web_contents_view_gtk_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 9 months ago (2012-03-02 17:00:54 UTC) #1
Elliot Glaysher
8 years, 9 months ago (2012-03-02 17:29:53 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698