Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9585028: Mac Aura fails compile and some tests (Closed)

Created:
8 years, 9 months ago by dhollowa
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Mac Aura fails compile and some tests Fixes compile errors and marks failing tests as FAILED to get bots green. Will tackle proper fixes to tests in follow-on CLs. BUG=None TEST=ShellTest.FAILS_OverlappingWindowModeBasics, CompactLayoutManagerTest.FAILS_TransitionTest, RootWindowEventFilterTest.FAILS_TransformActivate, ToplevelWindowEventFilterTest.FAILS_EscapeReverts R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M ash/system/brightness/tray_brightness.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/wm/compact_layout_manager_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ash/wm/root_window_event_filter_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ui/aura/env.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_point.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dhollowa
8 years, 9 months ago (2012-03-02 22:14:42 UTC) #1
sky
8 years, 9 months ago (2012-03-02 23:00:09 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698