Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6263)

Unified Diff: chrome/browser/webdata/autofill_table.h

Issue 9585020: Cull autofill entries older than 60 days. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: adressed comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/autofill_table.h
diff --git a/chrome/browser/webdata/autofill_table.h b/chrome/browser/webdata/autofill_table.h
index 4430f17cba4472d8c404c74898a51a207ed339ff..f9e9855f4eb85f22ac0ab5080688dbf36746bdef 100644
--- a/chrome/browser/webdata/autofill_table.h
+++ b/chrome/browser/webdata/autofill_table.h
@@ -154,8 +154,14 @@ class AutofillTable : public WebDatabaseTable {
const base::Time& delete_end,
std::vector<AutofillChange>* changes);
+ // Removes rows from autofill_dates if they were accessed strictly before
+ // |AutofillEntry::ExpirationTime()|. Removes corresponding row from autofill
Ilya Sherman 2012/03/20 21:25:13 nit: "Removes corresponding row" -> "Removes the c
GeorgeY 2012/03/21 20:56:40 Done.
+ // table. Also culls timestamps to only two. TODO(georgey): remove culling in
+ // future versions.
+ bool RemoveExpiredFormElements(std::vector<AutofillChange>* changes);
+
// Removes from autofill_dates rows with given pair_id where date_created lies
- // between delte_begin and delte_end.
+ // between |delete_begin| and |delete_end|.
bool RemoveFormElementForTimeRange(int64 pair_id,
const base::Time& delete_begin,
const base::Time& delete_end,
@@ -166,6 +172,10 @@ class AutofillTable : public WebDatabaseTable {
// |was_removed| out parameter to true if the count becomes 0.
bool AddToCountOfFormElement(int64 pair_id, int delta, bool* was_removed);
+ // Counts how many timestamp data rows are in the |autofill_dates| table for
+ // a given |pair_id|.
+ int CountTimestampsData(int64 pair_id);
Ilya Sherman 2012/03/20 21:25:13 This seems to be redundant with GetCountOfFormElem
GeorgeY 2012/03/21 20:56:40 Nope. Updated comment
Ilya Sherman 2012/03/21 21:20:53 Ah, makes sense -- thanks :)
+
// Gets the pair_id and count entries from name and value specified in
// |element|. Sets *pair_id and *count to 0 if there is no such row in
// the table.
@@ -187,6 +197,9 @@ class AutofillTable : public WebDatabaseTable {
// Adds a new row to the autofill_dates table.
bool InsertPairIDAndDate(int64 pair_id, const base::Time& date_created);
+ // Deletes last access to the Autofill data from the autofill_dates table.
+ bool DeleteLastAccess(int64 pair_id);
+
// Removes row from the autofill tables given |pair_id|.
bool RemoveFormElementForID(int64 pair_id);

Powered by Google App Engine
This is Rietveld 408576698