Cull autofill entries older than 60 days.

chrome/browser/webdata/web_data_service.cc

Index: chrome/browser/webdata/web_data_service.cc
diff --git a/chrome/browser/webdata/web_data_service.cc b/chrome/browser/webdata/web_data_service.cc
index e5f76d8cf8d6ce5fb07ccc382dac24428167b191..a4b79d9368e9de8997e0fc0e1b28267cacff265b 100644
--- a/chrome/browser/webdata/web_data_service.cc
+++ b/chrome/browser/webdata/web_data_service.cc
@@ -515,6 +515,15 @@ void WebDataService::RemoveFormElementsAddedBetween(const Time& delete_begin,
                     this, request));
 }
 
+void WebDataService::RemoveFormElementsAccessedBefore(const Time& delete_end) {
+  GenericRequest<Time>* request =
+      new GenericRequest<Time>(this, GetNextRequestHandle(), NULL, delete_end);
+  RegisterRequest(request);
+  ScheduleTask(FROM_HERE,
+               Bind(&WebDataService::RemoveFormElementsAccessedBeforeImpl,
+                    this, request));
+}

[Ilya Sherman, 2012/03/15 21:00:41]

I like exposing this API to clients of the WDS -- or even simplifying it further
to RemoveExpiredFormElements().  But, within the WDS implementation, it seems
much easier to make this be a simple wrapper around
WDS::RemoveFormElementsAddedBetween().  Am I missing a reason why that is a bad
idea?

[GeorgeY, 2012/03/17 00:36:16]

There are different functions: one removes all time stamps on the interval (t1,
t2) and is used from the cache clearing,
The  other removes 1. all items that were last accessed before some time. Culls
the entries to have only two timestamps. After we merge the tables will rid of
this function.

[Ilya Sherman, 2012/03/19 21:12:51]

Ok, that makes sense.  Please add a TODO to refactor away this function after
the tables are merged.

+
 void WebDataService::RemoveFormValueForElementName(
     const string16& name, const string16& value) {
   GenericRequest2<string16, string16>* request =
@@ -1258,6 +1267,31 @@ void WebDataService::RemoveFormElementsAddedBetweenImpl(
   request->RequestComplete();
 }
 
+void WebDataService::RemoveFormElementsAccessedBeforeImpl(
+    GenericRequest<Time>* request) {
+  InitializeDatabaseIfNecessary();
+  if (db_ && !request->IsCancelled(NULL)) {
+    AutofillChangeList changes;
+    if (db_->GetAutofillTable()->RemoveFormElementsAccessedBefore(
+        request->arg(), &changes)) {
+      if (!changes.empty()) {
+        request->SetResult(
+            new WDResult<AutofillChangeList>(AUTOFILL_CHANGES, changes));
+
+        // Post the notifications including the list of affected keys.
+        // This is sent here so that work resulting from this notification
+        // will be done on the DB thread, and not the UI thread.
+        content::NotificationService::current()->Notify(
+            chrome::NOTIFICATION_AUTOFILL_ENTRIES_CHANGED,
+            content::Source<WebDataService>(this),
+            content::Details<AutofillChangeList>(&changes));
+      }
+      ScheduleCommit();
+    }
+  }
+  request->RequestComplete();
+}
+
 void WebDataService::RemoveFormValueForElementNameImpl(
     GenericRequest2<string16, string16>* request) {
   InitializeDatabaseIfNecessary();