Cull autofill entries older than 60 days.

chrome/browser/webdata/autofill_table.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEBDATA_AUTOFILL_TABLE_H_
 #define CHROME_BROWSER_WEBDATA_AUTOFILL_TABLE_H_
 #pragma once
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
@@ skipping 136 matching lines @@
   // Removes rows from autofill_dates if they were created on or after
   // |delete_begin| and strictly before |delete_end|.  Decrements the
   // count of the corresponding rows in the autofill table, and
   // removes those rows if the count goes to 0.  A list of all changed
   // keys and whether each was updater or removed is returned in the
   // changes out parameter.
   bool RemoveFormElementsAddedBetween(const base::Time& delete_begin,
                                       const base::Time& delete_end,
                                       std::vector<AutofillChange>* changes);
 
+  // Removes rows from autofill_dates if they were accessed strictly before
+  // |delete_end|. Removes corresponding row from autofill table.
+  // Also culls timestamps to only two. TODO(georgey): remove culling in future
+  // versions.
+  bool RemoveExpiredFormElements(const base::Time& delete_end,

[Ilya Sherman, 2012/03/19 21:12:51]

nit: I find the fact that we're passing |delete_end| into here surprising.  It's
always set to AutofillEntry::ExpirationTime(), right?  If so, let's remove this
parameter and compute it in the implementation.

[GeorgeY, 2012/03/20 20:47:58]

sure

+                                 std::vector<AutofillChange>* changes);
+
   // Removes from autofill_dates rows with given pair_id where date_created lies
-  // between delte_begin and delte_end.
+  // between |delete_begin| and |delete_end|.
   bool RemoveFormElementForTimeRange(int64 pair_id,
                                      const base::Time& delete_begin,
                                      const base::Time& delete_end,
                                      int* how_many);
 
   // Increments the count in the row corresponding to |pair_id| by
   // |delta|.  Removes the row from the table and sets the
   // |was_removed| out parameter to true if the count becomes 0.
   bool AddToCountOfFormElement(int64 pair_id, int delta, bool* was_removed);
 
@@ skipping 11 matching lines @@
   bool SetCountOfFormElement(int64 pair_id, int count);
 
   // Adds a new row to the autofill table with name and value given in
   // |element|.  Sets *pair_id to the pair_id of the new row.
   bool InsertFormElement(const webkit::forms::FormField& element,
                          int64* pair_id);
 
   // Adds a new row to the autofill_dates table.
   bool InsertPairIDAndDate(int64 pair_id, const base::Time& date_created);
 
+  // Deletes last access to the Autofill data from the autofill_dates table.
+  bool DeleteLastAccess(int64 pair_id);
+
   // Removes row from the autofill tables given |pair_id|.
   bool RemoveFormElementForID(int64 pair_id);
 
   // Removes row from the autofill tables for the given |name| |value| pair.
   virtual bool RemoveFormElement(const string16& name, const string16& value);
 
   // Retrieves all of the entries in the autofill table.
   virtual bool GetAllAutofillEntries(std::vector<AutofillEntry>* entries);
 
   // Retrieves a single entry from the autofill table.
@@ skipping 136 matching lines @@
   bool InitProfilesTable();
   bool InitProfileNamesTable();
   bool InitProfileEmailsTable();
   bool InitProfilePhonesTable();
   bool InitProfileTrashTable();
 
   DISALLOW_COPY_AND_ASSIGN(AutofillTable);
 };
 
 #endif  // CHROME_BROWSER_WEBDATA_AUTOFILL_TABLE_H_