Cull autofill entries older than 60 days.

chrome/browser/webdata/autofill_entry.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEBDATA_AUTOFILL_ENTRY_H__
 #define CHROME_BROWSER_WEBDATA_AUTOFILL_ENTRY_H__
 #pragma once
 
 #include <stddef.h>
 #include <vector>
@@ skipping 28 matching lines @@
   ~AutofillEntry();
 
   const AutofillKey& key() const { return key_; }
   const std::vector<base::Time>& timestamps() const { return timestamps_; }
 
   bool operator==(const AutofillEntry& entry) const;
   bool operator<(const AutofillEntry& entry) const;
 
   bool timestamps_culled() const { return timestamps_culled_; }
 
+  // Checks if last of the timestamps are older than ExpirationTime().
+  bool IsExpired() const;
+
+  // The entries last accessed before this time should expire.
+  static base::Time ExpirationTime();
+
  private:
   FRIEND_TEST_ALL_PREFIXES(AutofillEntryTest, NoCulling);
   FRIEND_TEST_ALL_PREFIXES(AutofillEntryTest, Culling);
+  FRIEND_TEST_ALL_PREFIXES(AutofillEntryTest, CullByTime);
 
-  // Culls the list of timestamps to |kMaxAutofillTimeStamps| latest timestamps.
-  // Result is stored in |result|. If the original vtor's size is less
-  // than kMaxAutofillTimeStamps then false is returned. Otherwise true is
-  // returned. Note: source and result should be DIFFERENT vectors.
+  // Culls the list of timestamps to 2 - the oldest and most recent. This is a
+  // precursor to getting rid of the timestamps db altogether. (Issue #118696)

[Ilya Sherman, 2012/03/19 21:12:51]

nit: Please include a link to the issue, i.e. http://crbug.com/118696

[GeorgeY, 2012/03/20 20:47:58]

Done.

+  // |source| is expected to be sorted from oldest to newest.
   static bool CullTimeStamps(const std::vector<base::Time>& source,
                              std::vector<base::Time>* result);
 
   AutofillKey key_;
   std::vector<base::Time> timestamps_;
   bool timestamps_culled_;
+
+  // The period after which Autofill entries should expire in days.
+  static const int64 kExpirationPeriodInDays = 60;

[Ilya Sherman, 2012/03/19 21:12:51]

nit: Let's tuck this into the implementation file rather than the header.

[GeorgeY, 2012/03/20 20:47:58]

Done.

 };
 
-// TODO(lipalani): Move this inside the class defintion.
-const unsigned int kMaxAutofillTimeStamps = 50;
 #endif  // CHROME_BROWSER_WEBDATA_AUTOFILL_ENTRY_H__