Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 9585014: Change quota::QuotaClient::kAllClientsMask to be an enum. (Closed)

Created:
8 years, 9 months ago by mnaganov (inactive)
Modified:
8 years, 9 months ago
Reviewers:
kinuko, Mike West
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Change quota::QuotaClient::kAllClientsMask to be an enum. By the standard, static constants should also have a definition counterpart to allocate storage space. It's not strictly necessary for ints (but it puts usage restrictions on them), and for some reason we are having linking failure on Chrome on Android when building with clang compiler, maybe that's because of using templates or perhaps it's a clang issue. Anyway, converting this constant into an enum solves the problem. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webkit/quota/quota_client.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
8 years, 9 months ago (2012-03-02 15:15:25 UTC) #1
kinuko
8 years, 9 months ago (2012-03-02 18:49:22 UTC) #2
On 2012/03/02 15:15:25, Mikhail Naganov (Chromium) wrote:

LGTM

Powered by Google App Engine
This is Rietveld 408576698