Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 9584026: ChromeOS: Add more logs to troubleshoot plugin issues in login screen. (Closed)

Created:
8 years, 9 months ago by oshima
Modified:
8 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

ChromeOS: Add more logs to troubleshoot plugin issues in chromeos login screen. This is addition to http://codereview.chromium.org/9477021/ BUG=chromium-os:26646 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124762

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : fixed message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M webkit/plugins/ppapi/plugin_module.cc View 1 2 3 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
8 years, 9 months ago (2012-03-02 22:20:02 UTC) #1
oshima
brett, trung, can one of you approve this?
8 years, 9 months ago (2012-03-02 22:22:07 UTC) #2
xiyuan
LGTM But you need owner's approval.
8 years, 9 months ago (2012-03-02 22:47:47 UTC) #3
dmichael (off chromium)
Please be sure to remove this as soon as you're done getting the output you ...
8 years, 9 months ago (2012-03-02 22:53:28 UTC) #4
viettrungluu
lgtm with correction :) http://codereview.chromium.org/9584026/diff/6005/webkit/plugins/ppapi/plugin_module.cc File webkit/plugins/ppapi/plugin_module.cc (right): http://codereview.chromium.org/9584026/diff/6005/webkit/plugins/ppapi/plugin_module.cc#newcode541 webkit/plugins/ppapi/plugin_module.cc:541: LOG(ERROR) << "#### PluginModule::InitAsInternalPlugin name=" ...
8 years, 9 months ago (2012-03-02 23:07:01 UTC) #5
oshima
8 years, 9 months ago (2012-03-02 23:08:45 UTC) #6
On 2012/03/02 23:07:01, viettrungluu wrote:
> lgtm with correction :)
> 
>
http://codereview.chromium.org/9584026/diff/6005/webkit/plugins/ppapi/plugin_...
> File webkit/plugins/ppapi/plugin_module.cc (right):
> 
>
http://codereview.chromium.org/9584026/diff/6005/webkit/plugins/ppapi/plugin_...
> webkit/plugins/ppapi/plugin_module.cc:541: LOG(ERROR) << "####
> PluginModule::InitAsInternalPlugin name=" << name_;
> InitAsProxied

Ugh, thanks for the catch! Fixed.

Powered by Google App Engine
This is Rietveld 408576698