Issue 9584023: Move MockResourceContext to content/test.

Issue 9584023: Move MockResourceContext to content/test. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move MockResourceContext to content/test. BUG=98716 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124934

Patch Set 1 : #

Total comments: 4

Patch Set 2 : jam review #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -94 lines)			Patch
M	chrome/browser/DEPS	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gview_request_interceptor_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/testing_profile.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	content/browser/mock_resource_context.h	View		1 chunk	+0 lines, -42 lines	0 comments	Download
D	content/browser/mock_resource_context.cc	View		1 chunk	+0 lines, -35 lines	0 comments	Download
M	content/browser/renderer_host/media/audio_renderer_host_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/media/video_capture_host_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/content_tests.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A +	content/test/mock_resource_context.h	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
A +	content/test/mock_resource_context.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/test/test_browser_context.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/test/webrtc_audio_device_test.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm with at least the first change http://codereview.chromium.org/9584023/diff/5001/chrome/browser/DEPS File chrome/browser/DEPS (right): http://codereview.chromium.org/9584023/diff/5001/chrome/browser/DEPS#newcode80 chrome/browser/DEPS:80: "+content/test/mock_resource_context.h", this ...

8 years, 9 months ago (2012-03-05 06:51:59 UTC) #2

tfarina

8 years, 9 months ago (2012-03-05 12:40:34 UTC) #3

http://codereview.chromium.org/9584023/diff/5001/chrome/browser/DEPS
File chrome/browser/DEPS (right):

http://codereview.chromium.org/9584023/diff/5001/chrome/browser/DEPS#newcode80
chrome/browser/DEPS:80: "+content/test/mock_resource_context.h",
On 2012/03/05 06:51:59, John Abd-El-Malek wrote:
> this isn't needed, since chrome allows content/test

Done.

http://codereview.chromium.org/9584023/diff/5001/content/test/mock_resource_c...
File content/test/mock_resource_context.h (right):

http://codereview.chromium.org/9584023/diff/5001/content/test/mock_resource_c...
content/test/mock_resource_context.h:30: // Overridden from ResourceContext:
On 2012/03/05 06:51:59, John Abd-El-Malek wrote:
> nit: no need to change this when moving the file, we have a variety of ways
this
> is written

Done.

Expand Messages | Collapse Messages