Issue 9584020: To get the chromoting host list, pass the OAuth access token as a URL parameter,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9584020: To get the chromoting host list, pass the OAuth access token as a URL parameter, (Closed)

Created:
8 years, 9 months ago by simonmorris

Modified:
8 years, 9 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

To get the chromoting host list, pass the OAuth access token as a URL parameter, not in the headers. BUG=116574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124730

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rephrase comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	remoting/webapp/host_list.js	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jamie

8 years, 9 months ago (2012-03-02 20:42:54 UTC) #2

lgtm with one suggestion.

http://codereview.chromium.org/9584020/diff/1/remoting/webapp/host_list.js
File remoting/webapp/host_list.js (right):

http://codereview.chromium.org/9584020/diff/1/remoting/webapp/host_list.js#ne...
remoting/webapp/host_list.js:94: // Use URL parameters instead of headers, only
because of crbug.com/116574.
Can you rephrase this as a TODO, since we probably want to fix it at some point.

Expand Messages | Collapse Messages