Issue 9584016: [uber page] Implement "use shared proxies" and "add connection".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9584016: [uber page] Implement "use shared proxies" and "add connection". (Closed)

Created:
8 years, 9 months ago by kevers

Modified:
8 years, 9 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[uber page] Implement "use shared proxies" and "add connection". BUG=chromium:110749, chromium:112293 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124936

Patch Set 2 : Remove console spam and add documentation. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -88 lines)			Patch
	M	chrome/browser/resources/options2/chromeos/network_list.js	View	1	20 chunks	+230 lines, -88 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm w/ nits https://chromiumcodereview.appspot.com/9584016/diff/1/chrome/browser/resources/options2/chromeos/network_list.js File chrome/browser/resources/options2/chromeos/network_list.js (right): https://chromiumcodereview.appspot.com/9584016/diff/1/chrome/browser/resources/options2/chromeos/network_list.js#newcode583 chrome/browser/resources/options2/chromeos/network_list.js:583: console.log('fired callback to add a connection'); ...

8 years, 9 months ago (2012-03-03 02:21:41 UTC) #2

kevers

8 years, 9 months ago (2012-03-05 14:33:01 UTC) #3

https://chromiumcodereview.appspot.com/9584016/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/chromeos/network_list.js (right):

https://chromiumcodereview.appspot.com/9584016/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/chromeos/network_list.js:583:
console.log('fired callback to add a connection');
On 2012/03/03 02:21:41, csilv wrote:
> delete console.log (unless you really need it to be there).

Done.

https://chromiumcodereview.appspot.com/9584016/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/chromeos/network_list.js:691:
updateToggleControl: function(key, active) {
On 2012/03/03 02:21:41, csilv wrote:
> comment method

Done.

Expand Messages | Collapse Messages

Issue 9584016: [uber page] Implement "use shared proxies" and "add connection". (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove console spam and add documentation. #

Messages