Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 9584003: Re-land CL 9466047. (Closed)

Created:
8 years, 9 months ago by Sven Panne
Modified:
8 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Re-land CL 9466047. Main change from the original CL: Call::ComputeTarget does not use IsProperty anymore, because this would potentially need a holder, which we don't have here. Using Map::LookupInDescriptors with a NULL holder is a bit fishy in general, because one has to be *extremely* careful when using its LookupResult. The original CL made Chrome's NetInternalsTest.netInternalsTourTabs browser test fail, but it's a mystery how this could happen: We should never reach Call::ComputeTarget via Call::RecordTypeFeedback with a CALLBACKS property, because we never consider calls to them monomorphic, which is in turn because of the stub cache leaving them in the pre-monomorphic state. Therefore, I don't have a clue how to write a regression test for this... As an additional tiny bonus, the --trace-opt output for deoptimizations has been improved. Committed: https://code.google.com/p/v8/source/detail?r=10906

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -33 lines) Patch
M src/ast.cc View 1 chunk +19 lines, -6 lines 0 comments Download
M src/objects.h View 1 3 chunks +27 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/property.h View 2 chunks +31 lines, -3 lines 0 comments Download
M src/property-details.h View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sven Panne
8 years, 9 months ago (2012-03-02 08:05:36 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM but I would prefer to have a regression test. What happens if we have ...
8 years, 9 months ago (2012-03-02 10:18:45 UTC) #2
Vyacheslav Egorov (Chromium)
actually another thought: we don't have call-site precise information for polymorphic ICs so it's enough ...
8 years, 9 months ago (2012-03-02 10:20:12 UTC) #3
Vyacheslav Egorov (Chromium)
s/callbacks property/callbacks property with the same name/
8 years, 9 months ago (2012-03-02 10:20:41 UTC) #4
Erik Corry
8 years, 9 months ago (2012-03-05 07:09:08 UTC) #5
I would very much prefer if a CL description included a mention of which issue
the change fixes.

Powered by Google App Engine
This is Rietveld 408576698