Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 9583037: Reland r10908 (Ensure consistent result of transcendental function0.) (Closed)

Created:
8 years, 9 months ago by Yang
Modified:
8 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Reland r10908 (Ensure consistent result of transcendental function0.) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10915

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -28 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/heap-inl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +48 lines, -0 lines 1 comment Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 6 chunks +15 lines, -10 lines 2 comments Download
M src/x64/codegen-x64.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
I had to revert the first CL on this issue since there were two bugs. ...
8 years, 9 months ago (2012-03-03 11:05:01 UTC) #1
Sven Panne
http://codereview.chromium.org/9583037/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/9583037/diff/1/src/x64/code-stubs-x64.cc#newcode1729 src/x64/code-stubs-x64.cc:1729: // NaN is represented by 0x7ff8000000000000. On 2012/03/03 11:05:01, ...
8 years, 9 months ago (2012-03-05 07:45:47 UTC) #2
Sven Panne
8 years, 9 months ago (2012-03-05 08:14:19 UTC) #3
LGTM after short discussion: Loading the root register won't work, because that
would be per-Isolate, and the transcendental code is global.

Powered by Google App Engine
This is Rietveld 408576698