Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 9583036: Revert 124817 - Take extensions out of Profile into a profile-keyed service, ExtensionSystem. (Closed)

Created:
8 years, 9 months ago by vandebo (ex-Chrome)
Modified:
8 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, kkania, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, robertshield, brettw-cc_chromium.org, darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Revert 124817 - Take extensions out of Profile into a profile-keyed service, ExtensionSystem. This may be causing this crash: Note: Google Test filter = PrerenderBrowserTest.PrerenderUnload [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from PrerenderBrowserTest, where TypeParam = [ RUN ] PrerenderBrowserTest.PrerenderUnload [2464:2324:0302/211059:6709843:FATAL:profile_dependency_manager.cc(134)] Check failed: false. Attempted to access a Profile that was ShutDown(). This is most likely a heap smasher in progress. After ProfileKeyedService::Shutdown() completes, your service MUST NOT refer to depended Profile services again. Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. BUG=104095 TEST=Open and close an incognito window; should not crash. Review URL: http://codereview.chromium.org/9369013 TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -980 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 8 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 13 chunks +38 lines, -40 lines 0 comments Download
D chrome/browser/extensions/extension_system.h View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/extensions/extension_system.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D chrome/browser/extensions/extension_system_factory.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/extensions/extension_system_factory.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 2 chunks +8 lines, -15 lines 0 comments Download
D chrome/browser/extensions/test_extension_system.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/extensions/test_extension_system.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 4 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 7 chunks +33 lines, -18 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile.h View 6 chunks +35 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 6 chunks +30 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 9 chunks +163 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.h View 5 chunks +26 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 6 chunks +51 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vandebo (ex-Chrome)
8 years, 9 months ago (2012-03-03 06:42:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698