NTP: Fix a leak.

chrome/browser/ui/webui/ntp/suggestions_page_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/suggestions_page_handler.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 118 matching lines @@
   // TODO(georgey) clear blacklist.
 }
 
 void SuggestionsHandler::SetPagesValueFromTopSites(
     const history::MostVisitedURLList& data) {
   // TODO(georgey) - change to our suggestions pages - right now as a test
   // returns top 20 sites in reverse order.
   pages_value_.reset(new ListValue());
   for (size_t i = 0; i < data.size(); i++) {
     const history::MostVisitedURL& suggested_url = data[data.size() - i - 1];
+    if (suggested_url.url.is_empty())
+      continue;
+
     DictionaryValue* page_value = new DictionaryValue();
-    if (suggested_url.url.is_empty()) {
-      continue;
-    }
-
     NewTabUI::SetURLTitleAndDirection(page_value,
                                       suggested_url.title,
                                       suggested_url.url);
     pages_value_->Append(page_value);
   }
 }
 
 void SuggestionsHandler::OnSuggestionsURLsAvailable(
     const history::MostVisitedURLList& data) {
   SetPagesValueFromTopSites(data);
@@ skipping 15 matching lines @@
 }
 
 std::string SuggestionsHandler::GetDictionaryKeyForURL(const std::string& url) {
   return base::MD5String(url);
 }
 
 // static
 void SuggestionsHandler::RegisterUserPrefs(PrefService* prefs) {
   // TODO(georgey) add user preferences (such as own blacklist) as needed.
 }