Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3015)

Unified Diff: chrome/browser/ui/browser_init.cc

Issue 9583025: Revert 124583 (See crbug.com/114259) Original info for r124583 is: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_init.cc
===================================================================
--- chrome/browser/ui/browser_init.cc (revision 124738)
+++ chrome/browser/ui/browser_init.cc (working copy)
@@ -1179,16 +1179,16 @@
// specified on the command line. Filter out any urls that are to be
// restored by virtue of having been previously pinned.
AddUniqueURLs(pref.urls, &tabs);
+ } else if (pref.type == SessionStartupPref::HOMEPAGE && !tabs.empty()) {
+ // Make sure the home page is opened even if there are pinned tabs.
+ std::vector<GURL> urls;
+ AddStartupURLs(&urls);
+ UrlsToTabs(urls, &tabs);
} else if (pref.type == SessionStartupPref::DEFAULT) {
Tab tab;
tab.is_pinned = false;
tab.url = GURL(chrome::kChromeUINewTabURL);
tabs.push_back(tab);
- } else if (pref.type == SessionStartupPref::HOMEPAGE) {
- // If the user had 'homepage' selected, we should have migrated them to
- // 'URLs' instead.
- DLOG(ERROR) << "pref.type == HOMEPAGE";
- NOTREACHED();
}
if (tabs.empty())
« no previous file with comments | « chrome/browser/resources/options2/browser_options.html ('k') | chrome/browser/ui/webui/options2/browser_options_handler2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698