Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 9583009: [File Manager] Cleanup: Moving js/css/html files to dedicated directories (Closed)

Created:
8 years, 9 months ago by Vladislav Kaznacheev
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins, dgozman
CC:
chromium-reviews, feature-media-reviews_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Cleanup: Moving js/css/html files to dedicated directories This is pure refactoring patch, no new functionality is introduced. This retires gallery_demo.html which is superceded by harness.html. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124926

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment addressed #

Patch Set 3 : 2011->2012 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -5321 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 1 chunk +10 lines, -12 lines 0 comments Download
A + chrome/browser/resources/file_manager/css/gallery.css View 8 chunks +29 lines, -29 lines 0 comments Download
A + chrome/browser/resources/file_manager/css/media_controls.css View 6 chunks +32 lines, -32 lines 0 comments Download
A chrome/browser/resources/file_manager/gallery.html View 1 chunk +37 lines, -0 lines 0 comments Download
D chrome/browser/resources/file_manager/js/audio_player.js View 1 2 1 chunk +0 lines, -273 lines 0 comments Download
D chrome/browser/resources/file_manager/js/byte_reader.js View 1 chunk +0 lines, -412 lines 0 comments Download
D chrome/browser/resources/file_manager/js/exif_parser.js View 1 chunk +0 lines, -365 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/file_manager/js/function_parallel.js View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/resources/file_manager/js/function_sequence.js View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/resources/file_manager/js/id3_parser.js View 1 chunk +0 lines, -680 lines 0 comments Download
D chrome/browser/resources/file_manager/js/image_editor/gallery.css View 1 chunk +0 lines, -797 lines 0 comments Download
D chrome/browser/resources/file_manager/js/image_editor/gallery.html View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/gallery.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/file_manager/js/image_editor/gallery_demo.html View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/resources/file_manager/js/image_editor/image_editor.css View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/resources/file_manager/js/image_editor/media_controls.css View 1 chunk +0 lines, -491 lines 0 comments Download
D chrome/browser/resources/file_manager/js/image_editor/media_controls.js View 1 chunk +0 lines, -932 lines 0 comments Download
D chrome/browser/resources/file_manager/js/image_parsers.js View 1 chunk +0 lines, -93 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/media/audio_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/media/media_controls.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/byte_reader.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/exif_parser.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/function_parallel.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/function_sequence.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/id3_parser.js View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/image_parsers.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/metadata_parser.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/metadata_provider.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/resources/file_manager/js/metadata/mpeg_parser.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/file_manager/js/metadata_dispatcher.js View 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/browser/resources/file_manager/js/metadata_parser.js View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/resources/file_manager/js/metadata_provider.js View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/resources/file_manager/js/mpeg_parser.js View 1 chunk +0 lines, -262 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/mediaplayer.html View 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/browser/resources/file_manager/playlist.html View 1 chunk +0 lines, -155 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vladislav Kaznacheev
Please review. Best regards, Vlad
8 years, 9 months ago (2012-03-02 12:50:56 UTC) #1
dgozman
LGTM! https://chromiumcodereview.appspot.com/9583009/diff/1/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): https://chromiumcodereview.appspot.com/9583009/diff/1/chrome/browser/resources/component_extension_resources.grd#newcode34 chrome/browser/resources/component_extension_resources.grd:34: <include name="IDR_FILE_MANAGER_METADATA_READER" file="file_manager/js/metadata/byte_reader.js" type="BINDATA" /> Two byte readers.
8 years, 9 months ago (2012-03-02 13:18:08 UTC) #2
Vladislav Kaznacheev
Hi James, Please review my changes to component_extension_resources.grd. Thanks, Vlad https://chromiumcodereview.appspot.com/9583009/diff/1/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): https://chromiumcodereview.appspot.com/9583009/diff/1/chrome/browser/resources/component_extension_resources.grd#newcode34 ...
8 years, 9 months ago (2012-03-02 14:48:19 UTC) #3
James Hawkins
component_extension_resources.grd LGTM
8 years, 9 months ago (2012-03-02 22:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9583009/2002
8 years, 9 months ago (2012-03-05 07:30:20 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-05 07:30:48 UTC) #6
Presubmit check for 9583009-2002 failed and returned exit status 1.

/mnt/data/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/javascriptlintrules.py:28:
DeprecationWarning: the sets module is deprecated
  from sets import Set
Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/browser/resources/file_manager/css/gallery.css, line 336, 89 chars \
  chrome/browser/resources/file_manager/css/gallery.css, line 340, 90 chars \
  chrome/browser/resources/file_manager/css/gallery.css, line 344, 130 chars \
  chrome/browser/resources/file_manager/css/media_controls.css, line 24, 82
chars \
  chrome/browser/resources/file_manager/css/media_controls.css, line 27, 82
chars

Presubmit checks took 1.5s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698