Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/uber/uber.html

Issue 9582032: [uber page] Integrate history into uber page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/browser_about_handler.cc ('K') | « chrome/browser/resources/history/history.js ('k') | chrome/browser/resources/uber/uber_frame.css » ('j') | chrome/browser/ui/webui/uber/uber_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/uber/uber.html
===================================================================
--- chrome/browser/resources/uber/uber.html (revision 124713)
+++ chrome/browser/resources/uber/uber.html (working copy)
@@ -20,15 +20,18 @@
<div id="navigation"><iframe src="chrome://uber-frame/"></iframe></div>
-<div class="iframe-container" i18n-values="id:settingsHost"
- data-favicon="chrome://theme/IDR_SETTINGS_FAVICON"
- data-url="chrome://settings-frame/"></div>
-<div class="iframe-container" i18n-values="id:extensionsHost"
- data-favicon="chrome://theme/IDR_EXTENSIONS_FAVICON"
- data-url="chrome://extensions-frame/"></div>
-<div class="iframe-container" i18n-values="id:helpHost"
- data-favicon="chrome://theme/IDR_PRODUCT_LOGO_16"
- data-url="chrome://help-frame/"></div>
+<div class="iframe-container"
+ i18n-values="id:historyHost;data-url:historyFrameURL;"
+ data-favicon="chrome://theme/IDR_HISTORY_FAVICON"></div>
+<div class="iframe-container"
+ i18n-values="id:extensionsHost;data-url:extensionsFrameURL;"
+ data-favicon="chrome://theme/IDR_EXTENSIONS_FAVICON"></div>
+<div class="iframe-container"
+ i18n-values="id:settingsHost;data-url:settingsFrameURL;"
Evan Stade 2012/03/02 23:29:54 you should use a space to separate the attributes
csilv 2012/03/02 23:48:09 Done.
+ data-favicon="chrome://theme/IDR_SETTINGS_FAVICON"></div>
+<div class="iframe-container"
+ i18n-values="id:helpHost;data-url:helpFrameURL;"
+ data-favicon="chrome://theme/IDR_PRODUCT_LOGO_16"></div>
<script src="chrome://chrome/strings.js"></script>
<script src="chrome://resources/js/i18n_template.js"></script>
« chrome/browser/browser_about_handler.cc ('K') | « chrome/browser/resources/history/history.js ('k') | chrome/browser/resources/uber/uber_frame.css » ('j') | chrome/browser/ui/webui/uber/uber_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698