Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 9582019: more logs for 26646 (Closed)

Created:
8 years, 9 months ago by oshima
Modified:
8 years, 9 months ago
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
8 years, 9 months ago (2012-03-02 19:11:34 UTC) #1
oshima
8 years, 9 months ago (2012-03-02 19:13:27 UTC) #2
Jorge Lucangeli Obes
https://chromiumcodereview.appspot.com/9582019/diff/1/chrome/browser/automation/automation_provider.cc File chrome/browser/automation/automation_provider.cc (right): https://chromiumcodereview.appspot.com/9582019/diff/1/chrome/browser/automation/automation_provider.cc#newcode266 chrome/browser/automation/automation_provider.cc:266: VLOG(2) << "SetExpectedTabCount:" << expected_tabs; No #if defined(OS_CHROMEOS)? https://chromiumcodereview.appspot.com/9582019/diff/1/chrome/browser/automation/automation_provider_observers.cc ...
8 years, 9 months ago (2012-03-02 19:15:57 UTC) #3
oshima
https://chromiumcodereview.appspot.com/9582019/diff/1/chrome/browser/automation/automation_provider.cc File chrome/browser/automation/automation_provider.cc (right): https://chromiumcodereview.appspot.com/9582019/diff/1/chrome/browser/automation/automation_provider.cc#newcode266 chrome/browser/automation/automation_provider.cc:266: VLOG(2) << "SetExpectedTabCount:" << expected_tabs; On 2012/03/02 19:15:57, Jorge ...
8 years, 9 months ago (2012-03-02 19:21:49 UTC) #4
Jorge Lucangeli Obes
lgtm
8 years, 9 months ago (2012-03-02 19:23:22 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-02 19:46:37 UTC) #6
Jorge Lucangeli Obes
Oh right forgot about that! I'm only a full committer for Chrome OS.
8 years, 9 months ago (2012-03-02 19:49:15 UTC) #7
xiyuan
lgtm
8 years, 9 months ago (2012-03-02 20:21:57 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 20:22:28 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698