Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 9582013: Revert 124660 - Allow comments in extension config files. (Closed)

Created:
8 years, 9 months ago by yzshen1
Modified:
8 years, 9 months ago
Reviewers:
yzshen, cduvall
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Revert 124660 - Allow comments in extension config files. Added a script to remove comments from the extension api JSON files before processing for the extension docs. We will now be able to comment in the JSON files, and they should be much easier to read. Also added the license header to all the JSON files. BUG=114233 TEST=Put comments in one of the JSON files and remake the docs. They will make with no problems. Review URL: http://codereview.chromium.org/9447090 TBR=cduvall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -538 lines) Patch
MM chrome/common/extensions/api/bookmarks.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/browserAction.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/browsingData.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/chromeAuthPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/chromePrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/chromeosInfoPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/contentSettings.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/contextMenus.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/cookies.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/debugger.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/devtools.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/devtools_api.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.accessibility.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.app.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.bookmarkManager.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.declarative.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.dns.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.downloads.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/experimental.extension.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.fonts.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.infobars.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.input.ui.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/experimental.input.virtualKeyboard.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.keybinding.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.processes.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/experimental.rlz.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.serial.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/experimental.socket.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/experimental.speechInput.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/experimental.topSites.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/extension.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/fileBrowserHandler.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/fileBrowserPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/history.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/i18n.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/idle.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/input.ime.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/inputMethodPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/management.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/mediaPlayerPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/metricsPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/omnibox.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/pageAction.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/pageActions.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/pageCapture.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/permissions.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/privacy.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/proxy.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/storage.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/systemPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/terminalPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/test.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/tts.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/ttsEngine.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/types.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/webNavigation.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/webRequest.json View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/common/extensions/api/webSocketProxyPrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/webstorePrivate.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/windows.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/build/directory.py View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/common/extensions/docs/template/page_shell.html View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/json_minify/README View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/json_minify/README.chromium View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/json_minify/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/json_minify/minify-sans-regexp.js View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/json_minify/minify_json.py View 1 chunk +0 lines, -112 lines 0 comments Download
M tools/json_schema_compiler/compiler.py View 3 chunks +5 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator_test.py View 1 chunk +4 lines, -4 lines 0 comments Download
D tools/json_schema_compiler/json_schema.py View 1 chunk +0 lines, -19 lines 0 comments Download
M tools/json_schema_compiler/model_test.py View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/previewserver.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yzshen1
8 years, 9 months ago (2012-03-02 17:26:30 UTC) #1
yzshen
Here is the output of the bot: python src/tools/checklicenses/checklicenses.py --root src in dir /b/build/slave/Linux/build (timeout ...
8 years, 9 months ago (2012-03-02 17:30:04 UTC) #2
cduvall
8 years, 9 months ago (2012-03-03 21:22:47 UTC) #3
Fixed the license headers. Sorry about that.

Powered by Google App Engine
This is Rietveld 408576698