Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3123)

Unified Diff: chrome/browser/ui/browser_init.cc

Issue 9582008: Revert r124635 "Record taskbar launch mode in UMA histogram" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_init.cc
diff --git a/chrome/browser/ui/browser_init.cc b/chrome/browser/ui/browser_init.cc
index 03354148bf9594c25d1c4228d90d3dd79351498d..c3b3a4a27d6218717fc0a8bb5e60573b129fecff 100644
--- a/chrome/browser/ui/browser_init.cc
+++ b/chrome/browser/ui/browser_init.cc
@@ -127,7 +127,6 @@
#endif
#if defined(OS_WIN)
-#include "base/win/windows_version.h"
#include "chrome/installer/util/auto_launch_util.h"
#endif
@@ -493,7 +492,7 @@ enum LaunchMode {
LM_SHORTCUT_UNKNOWN, // Launched from user-defined shortcut.
LM_SHORTCUT_QUICKLAUNCH, // Launched from the quick launch bar.
LM_SHORTCUT_DESKTOP, // Launched from a desktop shortcut.
- LM_SHORTCUT_TASKBAR, // Launched from the taskbar.
+ LM_SHORTCUT_STARTMENU, // Launched from start menu.
LM_LINUX_MAC_BEOS // Other OS buckets start here.
};
@@ -507,14 +506,10 @@ LaunchMode GetLaunchShortcutKind() {
if (si.dwFlags & 0x800) {
if (!si.lpTitle)
return LM_SHORTCUT_NONAME;
- string16 shortcut(si.lpTitle);
+ std::wstring shortcut(si.lpTitle);
// The windows quick launch path is not localized.
- if (shortcut.find(L"\\Quick Launch\\") != string16::npos) {
- if (base::win::GetVersion() >= base::win::VERSION_WIN7)
- return LM_SHORTCUT_TASKBAR;
- else
- return LM_SHORTCUT_QUICKLAUNCH;
- }
+ if (shortcut.find(L"\\Quick Launch\\") != std::wstring::npos)
+ return LM_SHORTCUT_QUICKLAUNCH;
scoped_ptr<base::Environment> env(base::Environment::Create());
std::string appdata_path;
env->GetVar("USERPROFILE", &appdata_path);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698