Added proper extensions for hosted documents.

Added proper extensions for hosted documents.

BUG=chromium-os:27223
TEST=GDataFileSystemTest.SearchExistingDocument
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124775

[satorux1, 2012-03-02 22:13:01]

LGTM with nits:

https://chromiumcodereview.appspot.com/9581024/diff/3001/chrome/browser/chrom...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/9581024/diff/3001/chrome/browser/chrom...
chrome/browser/chromeos/gdata/gdata_file_system.cc:177:
doc->GetHostedDocumentExtension().c_str()));
EscapeFileName(file->original_file_name + doc->GetHostedDocumentExtension())
would suffice.

https://chromiumcodereview.appspot.com/9581024/diff/3001/chrome/browser/chrom...
File chrome/browser/chromeos/gdata/gdata_parser.cc (right):

https://chromiumcodereview.appspot.com/9581024/diff/3001/chrome/browser/chrom...
chrome/browser/chromeos/gdata/gdata_parser.cc:52: { DocumentEntry::PDF,         
"pdf"},
Add NULL to the last four types?

[zel, 2012-03-02 22:54:51]

PTAL, I've wired proper extension handling all the way to the UI layer now.

https://chromiumcodereview.appspot.com/9581024/diff/3001/chrome/browser/chrom...
File chrome/browser/chromeos/gdata/gdata_parser.cc (right):

https://chromiumcodereview.appspot.com/9581024/diff/3001/chrome/browser/chrom...
chrome/browser/chromeos/gdata/gdata_parser.cc:52: { DocumentEntry::PDF,         
"pdf"},
On 2012/03/02 22:13:01, satorux1 wrote:
> Add NULL to the last four types?

Done already, forgot to upload it originally.

[satorux1, 2012-03-02 22:59:19]

LGTM with few regex errors.

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/file_type.js (right):

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_type.js:79: pattern:
/\.gslides/i},
$ is missing? using regexes for file types doesn't sound right, but not your
fault.

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_type.js:81: pattern: /\.gdraw/i},
ditto

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_type.js:83: pattern: /\.gtable/i},
ditto

[zel, 2012-03-02 23:01:42]

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/file_type.js (right):

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_type.js:79: pattern:
/\.gslides/i},
On 2012/03/02 22:59:19, satorux1 wrote:
> $ is missing? using regexes for file types doesn't sound right, but not your
> fault.

Done.

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_type.js:81: pattern: /\.gdraw/i},
On 2012/03/02 22:59:19, satorux1 wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9581024/diff/1010/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_type.js:83: pattern: /\.gtable/i},
On 2012/03/02 22:59:19, satorux1 wrote:
> ditto

Done.

[zel, 2012-03-02 23:32:03]

added UI folks as FYI

[commit-bot: I haz the power, 2012-03-02 23:33:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/9581024/7022

[commit-bot: I haz the power, 2012-03-02 23:33:49]

Presubmit check for 9581024-7022 failed and returned exit status 1.

/mnt/data/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/javascriptlintrules.py:28:
DeprecationWarning: the sets module is deprecated
  from sets import Set
Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/file_manager/js/file_manager.js,chrome/browser/resources/file_manager/css/file_manager.css,chrome/browser/resources/file_manager/js/file_type.js

Presubmit checks took 1.4s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[csilv, 2012-03-02 23:36:25]

lgtm, chrome/browser/resources/*