Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: chrome/browser/resources/net_internals/timeline_view.js

Issue 9581021: [refactor] Split up SourceTracker into SourceTracker + EventsTracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update based on mmenke comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/net_internals/source_tracker.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/net_internals/timeline_view.js
diff --git a/chrome/browser/resources/net_internals/timeline_view.js b/chrome/browser/resources/net_internals/timeline_view.js
index ba5c9a983c888bb9420f0433076f75b48337686a..e0e78cf0aa41c67952143909b08c271639f60abc 100644
--- a/chrome/browser/resources/net_internals/timeline_view.js
+++ b/chrome/browser/resources/net_internals/timeline_view.js
@@ -51,7 +51,7 @@ var TimelineView = (function() {
// them on to each DataSource. We initialize the graph range to initially
// include all events, but after that, we only update it to be the current
// time on a timer.
- g_browser.sourceTracker.addLogEntryObserver(this);
+ EventsTracker.getInstance().addLogEntryObserver(this);
this.graphRangeInitialized_ = false;
}
@@ -231,8 +231,7 @@ var TimelineView = (function() {
},
/**
- * When log entries are deleted, simpler to recreate the DataSeries, rather
- * than clearing them.
+ * When all log entries are deleted, recreate the DataSeries.
*/
onAllLogEntriesDeleted: function() {
this.graphRangeInitialized_ = false;
@@ -241,7 +240,7 @@ var TimelineView = (function() {
onReceivedLogEntries: function(entries) {
// Pass each entry to every DataSeries, one at a time. Not having each
- // data series get data directly from the SourceTracker saves us from
+ // data series get data directly from the EventsTracker saves us from
// having very un-Javascript-like destructors for when we load new,
// constants and slightly simplifies DataSeries objects.
for (var entry = 0; entry < entries.length; ++entry) {
« no previous file with comments | « chrome/browser/resources/net_internals/source_tracker.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698