Get rid of chrome dependencies from tab_contents_drag_win.cc. After this I'll move it to content\br…

Get rid of chrome dependencies from tab_contents_drag_win.cc. After this I'll move it to content\browser\tab_contents.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124701

[dcheng, 2012-03-02 18:54:47]

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
File chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h (right):

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h:88:
gfx::NativeWindow source_wnd_;
Seems a little unfortunate that we turn 1 pointer into 3 closely related
pointers. Would it make sense to put a thin content interface around this so we
carry these pointers around together?

[jam, 2012-03-02 18:56:37]

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
File chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h (right):

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h:88:
gfx::NativeWindow source_wnd_;
On 2012/03/02 18:54:47, dcheng wrote:
> Seems a little unfortunate that we turn 1 pointer into 3 closely related
> pointers. Would it make sense to put a thin content interface around this so
we
> carry these pointers around together?

I prefer not adding a new interface just to carry three pointers. the more files
we have in content\public, the more daunting it seems to newcomers.

[dcheng, 2012-03-02 19:04:17]

lgtm

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
File chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h (right):

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h:88:
gfx::NativeWindow source_wnd_;
On 2012/03/02 18:56:37, John Abd-El-Malek wrote:
> On 2012/03/02 18:54:47, dcheng wrote:
> > Seems a little unfortunate that we turn 1 pointer into 3 closely related
> > pointers. Would it make sense to put a thin content interface around this so
> we
> > carry these pointers around together?
> 
> I prefer not adding a new interface just to carry three pointers. the more
files
> we have in content\public, the more daunting it seems to newcomers.

OK, I'm not too thrilled with this part of the change but I won't block it based
on that.

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h:88:
gfx::NativeWindow source_wnd_;
Minor nit: window_ instead of wnd_. Similar for other places that use wnd.

[jam, 2012-03-02 19:09:59]

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
File chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h (right):

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h:88:
gfx::NativeWindow source_wnd_;
On 2012/03/02 19:04:17, dcheng wrote:
> Minor nit: window_ instead of wnd_. Similar for other places that use wnd.

Done.

http://codereview.chromium.org/9581003/diff/1/chrome/browser/ui/views/tab_con...
chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h:88:
gfx::NativeWindow source_wnd_;
On 2012/03/02 19:04:17, dcheng wrote:
> On 2012/03/02 18:56:37, John Abd-El-Malek wrote:
> > On 2012/03/02 18:54:47, dcheng wrote:
> > > Seems a little unfortunate that we turn 1 pointer into 3 closely related
> > > pointers. Would it make sense to put a thin content interface around this
so
> > we
> > > carry these pointers around together?
> > 
> > I prefer not adding a new interface just to carry three pointers. the more
> files
> > we have in content\public, the more daunting it seems to newcomers.
> 
> OK, I'm not too thrilled with this part of the change but I won't block it
based
> on that.

I think this may be a personal style difference :) I think classes that take 3
or 4 arguments is quite normal. an interface would be useful if this value can
change later and so a cache won't work. but in this situation, it would make the
code less readable imo.