Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: vm/code_generator.cc

Issue 9580036: - Always write a Null Object for Code objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/code_generator.cc
===================================================================
--- vm/code_generator.cc (revision 4911)
+++ vm/code_generator.cc (working copy)
@@ -1136,6 +1136,11 @@
void FunctionsCache::AddCompiledFunction(const Function& function,
int num_arguments,
int num_named_arguments) {
+// TODO(srdjan): Evaluate if populating the function cache is needed.
+// It is turned off currently because we do not populate code objects
+// in snapshot and hence end up in an inconsistent state as function
+// cache is populated but there are no code objects.
+#if 0
ASSERT(function.HasCode());
Array& cache = Array::Handle(class_.functions_cache());
// Search for first free slot. Last entry is always NULL object.
@@ -1158,6 +1163,7 @@
function,
num_arguments,
num_named_arguments);
+#endif
}
« no previous file with comments | « no previous file | vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698