- Always write a Null Object for Code objects

vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 44 matching lines @@
 
 // Return error if isolate is in an inconsistent state.
 // Return NULL when no error condition exists.
 const char* CheckIsolateState(Isolate* isolate, bool generating_snapshot) {
   bool success = true;
   if (!ClassFinalizer::AllClassesFinalized()) {
     success = (generating_snapshot) ?
         ClassFinalizer::FinalizePendingClassesForSnapshotCreation() :
         ClassFinalizer::FinalizePendingClasses();
   }
-  if (success && !generating_snapshot) {
+  if (success) {
     success = isolate->object_store()->PreallocateObjects();
+    if (success) {
+      return NULL;
+    }
   }
-  if (success) {
-    return NULL;
-  } else {
-    // Make a copy of the error message as the original message string
-    // may get deallocated when we return back from the Dart API call.
-    const Error& err =
-        Error::Handle(isolate->object_store()->sticky_error());
-    const char* errmsg = err.ToErrorCString();
-    intptr_t errlen = strlen(errmsg) + 1;
-    char* msg = reinterpret_cast<char*>(Api::Allocate(errlen));
-    OS::SNPrint(msg, errlen, "%s", errmsg);
-    return msg;
-  }
+  // Make a copy of the error message as the original message string
+  // may get deallocated when we return back from the Dart API call.
+  const Error& err = Error::Handle(isolate->object_store()->sticky_error());
+  const char* errmsg = err.ToErrorCString();
+  intptr_t errlen = strlen(errmsg) + 1;
+  char* msg = reinterpret_cast<char*>(Api::Allocate(errlen));
+  OS::SNPrint(msg, errlen, "%s", errmsg);
+  return msg;
 }
 
 
 void SetupErrorResult(Dart_Handle* handle) {
   const Error& error = Error::Handle(
       Isolate::Current()->object_store()->sticky_error());
   *handle = Api::NewLocalHandle(error);
 }
 
 
@@ skipping 2621 matching lines @@
       *buffer = NULL;
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 }  // namespace dart