Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 9580024: ash uber tray: Allow customizing each item depending on whether the user is logged in or not. (Closed)

Created:
8 years, 9 months ago by sadrul
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

ash uber tray: Allow customizing each item depending on whether the user is logged in or not. If a user is not logged in (e.g. in the login screen, or during an incognito session), some of the items need to behave differently. So provide this information to each of the items so that such customization is possible. Also, make sure all the items get a chance to update themselves when user logs in. BUG=110130 TEST=tested on device, logged in as normal user, and incognito. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124863

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -280 lines) Patch
M ash/ash.gyp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ash/ash_strings.grd View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M ash/system/audio/tray_volume.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/audio/tray_volume.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/brightness/tray_brightness.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/brightness/tray_brightness.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/power/tray_power_date.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/power/tray_power_date.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/settings/tray_settings.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/settings/tray_settings.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 4 chunks +33 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_item.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ash/system/tray_user.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
M ash/system/tray_user.cc View 1 1 chunk +0 lines, -173 lines 0 comments Download
A ash/system/user/login_status.h View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A + ash/system/user/tray_user.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + ash/system/user/tray_user.cc View 1 2 3 4 chunks +47 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 5 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
8 years, 9 months ago (2012-03-02 22:42:18 UTC) #1
Ben Goodger (Google)
8 years, 9 months ago (2012-03-03 00:28:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698