Silence genperf's success-related chatter.

Silence genperf's success-related chatter.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124750

[Ami GONE FROM CHROMIUM, 2012-03-02 21:29:24]

Nico: PTAL.

[Nico, 2012-03-02 21:32:48]

Thanks!

Can you also send a pull request to the project upstream
(https://github.com/yasm/yasm) and add a link to that to the README.chromium
file?

https://chromiumcodereview.appspot.com/9580022/diff/1/patched-yasm/tools/genp...
File patched-yasm/tools/genperf/perfect.c (right):

https://chromiumcodereview.appspot.com/9580022/diff/1/patched-yasm/tools/genp...
patched-yasm/tools/genperf/perfect.c:676: /* printf("success, found a perfect
hash\n"); */
Can you delete them instead?

[Ami GONE FROM CHROMIUM, 2012-03-02 21:56:09]

On 2012/03/02 21:32:48, Nico wrote:
> Thanks!
> 
> Can you also send a pull request to the project upstream
> (https://github.com/yasm/yasm) and add a link to that to the README.chromium
> file?

ISTM that'd require making the printf's somehow optional and I don't really want
to get into that business.
(or do you have information that says that upstream doesn't care for these
printf's, either?)

>
https://chromiumcodereview.appspot.com/9580022/diff/1/patched-yasm/tools/genp...
> File patched-yasm/tools/genperf/perfect.c (right):
> 
>
https://chromiumcodereview.appspot.com/9580022/diff/1/patched-yasm/tools/genp...
> patched-yasm/tools/genperf/perfect.c:676: /* printf("success, found a perfect
> hash\n"); */
> Can you delete them instead?

I could but I find commenting-out to be clearer.

[Nico, 2012-03-02 22:04:52]

> ISTM that'd require making the printf's somehow optional and I don't really
want
> to get into that business.
> (or do you have information that says that upstream doesn't care for these
> printf's, either?)

No, just send them a patch that deletes them. I suppose they are from when the
program took longer than 10ms to run.

> I could but I find commenting-out to be clearer.

http://www.markhneedham.com/blog/2009/01/17/the-danger-of-commenting-out-code/
is roughly my thought on this

[Ami GONE FROM CHROMIUM, 2012-03-02 22:18:26]

Ok, removed instead of commented, and sent pull request.
Since I see you have an account on yasm's bugtracker would you mind opening a
ticket to point to the pull request?  Or is that not necessary?

http://tortall.lighthouseapp.com/projects/78676-yasm/overview
https://github.com/yasm/yasm/pull/61

[Nico, 2012-03-02 22:25:55]

LGTM

Just the pull request is sufficient, I think.