Issue 9580016: Fixed remaining CL comments from review of http://codereview.chromium.org/9561009/

Issue 9580016: Fixed remaining CL comments from review of http://codereview.chromium.org/9561009/ (Closed)

Created:
8 years, 9 months ago by zel

Modified:
8 years, 9 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fixed remaining CL comments from review of http://codereview.chromium.org/9561009/ BUG=chromium-os:26961 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124742

Patch Set 5 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -71 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		4 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc	View		4 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1 2 3 4	12 chunks	+73 lines, -58 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zel

fixes for remaining comments from http://codereview.chromium.org/9561009/

8 years, 9 months ago (2012-03-02 19:08:26 UTC) #1

satorux1

LGTM, with one nit: http://codereview.chromium.org/9580016/diff/3005/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right): http://codereview.chromium.org/9580016/diff/3005/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc#newcode401 chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:401: EXPECT_EQ(FilePath("gdata/New Folder 1"), first_missing_parent_path); nit: ...

8 years, 9 months ago (2012-03-02 21:31:24 UTC) #2

zel

https://chromiumcodereview.appspot.com/9580016/diff/3005/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right): https://chromiumcodereview.appspot.com/9580016/diff/3005/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc#newcode401 chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:401: EXPECT_EQ(FilePath("gdata/New Folder 1"), first_missing_parent_path); On 2012/03/02 21:31:24, satorux1 wrote: ...

8 years, 9 months ago (2012-03-02 21:46:44 UTC) #3

LGTM. file names are hard.

Expand Messages | Collapse Messages