Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 9580001: Aura: Update window frames, allow resize from outside window (Closed)

Created:
8 years, 9 months ago by James Cook
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, ben+watch_chromium.org, tfarina, piman+watch_chromium.org
Visibility:
Public.

Description

Aura: Update window frames, allow resize from outside window * New window frames, still behind a flag as there's more refinement to do for incognito, popups, and maximized windows. * Translucent frames now only require a single layer the size of the window instead of two. We may be able to cut the layer size in the future to the area of the window header + toolbar * Rewrite BrowserNonClientFrameViewAura * Use updated art assets from crrev.com/124602 * Allow windows optionally to specify that hit tests should include a region a few pixels outside the window. For Aura browser windows this area acts as non-client area resize handles which we need because the window frame borders are now very thin or not present at all. BUG=113075 TEST=manual, visual inspection of browser active, inactive, incognito, popup, hosted, and app windows. Updated aura_unittest for Window to check the expanded bounds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124743

Patch Set 1 #

Patch Set 2 : Fix caption for maximized windows, new resize cursor tweak #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -578 lines) Patch
M ash/wm/shadow_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 2 chunks +8 lines, -68 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h View 1 2 chunks +50 lines, -44 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 1 4 chunks +410 lines, -454 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M ui/aura/window.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M ui/gfx/compositor/debug_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/resources/ui_resources.grd View 1 1 chunk +29 lines, -0 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
James Cook
Dave, please take a look at chrome/* Ben, please take a look at ash/* and ...
8 years, 9 months ago (2012-03-02 19:17:54 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-02 21:16:26 UTC) #2
DaveMoore
8 years, 9 months ago (2012-03-02 21:51:32 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698