Add getFontList() to Font Settings Extension API.

Add getFontList() to Font Settings Extension API.

BUG=114148
TEST=browser_tests --gtest_filter=ExtensionApiTest.FontSettings


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124648

[falken, 2012-03-01 22:49:14]

Matt: Can you please review? Thanks.
Jungshik: FYI

[Matt Perry, 2012-03-01 22:57:29]

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_font_settings_api.cc (right):

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:115: ListValue* result
= new ListValue();
Use a scoped_ptr to avoid leaking result.

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:117: ListValue
*fontListValue;
ListValue* font_list_value

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:129: std::string
localizedName;
naming style

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:135: DictionaryValue*
fontName = new DictionaryValue();
ditto

[falken, 2012-03-01 23:30:52]

Thanks for the review.

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_font_settings_api.cc (right):

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:115: ListValue* result
= new ListValue();
On 2012/03/01 22:57:29, Matt Perry wrote:
> Use a scoped_ptr to avoid leaking result.

Done.

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:117: ListValue
*fontListValue;
On 2012/03/01 22:57:29, Matt Perry wrote:
> ListValue* font_list_value

Done.

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:129: std::string
localizedName;
On 2012/03/01 22:57:29, Matt Perry wrote:
> naming style

Done.

https://chromiumcodereview.appspot.com/9576001/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_font_settings_api.cc:135: DictionaryValue*
fontName = new DictionaryValue();
On 2012/03/01 22:57:29, Matt Perry wrote:
> ditto

Done.

[Matt Perry, 2012-03-01 23:35:24]

lgtm

[commit-bot: I haz the power, 2012-03-01 23:37:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/9576001/7001

[commit-bot: I haz the power, 2012-03-02 00:52:22]

Try job failure for 9576001-7001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-02 10:42:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/9576001/7001

[commit-bot: I haz the power, 2012-03-02 15:56:06]

Change committed as 124648