Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 9572033: Revert 124813 - Improve switch between gestures and touch mode when kEnableTouchEvents (Closed)

Created:
8 years, 9 months ago by vandebo (ex-Chrome)
Modified:
8 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Revert 124813 - Improve switch between gestures and touch mode when kEnableTouchEvents Mostly works, the only problem is that the first touch or gesture on switching "modes" gets lost because Windows doesn't start a touch of the "other" type when TouchRegisterWindow is called while there's a touch in progress. TBR=cpu Review URL: http://codereview.chromium.org/9549020 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124830

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
vandebo (ex-Chrome)
8 years, 9 months ago (2012-03-03 04:22:56 UTC) #1
scottmg
On 2012/03/03 04:22:56, vandebo wrote: Thanks for tracking this down. I guess it broke XP-only ...
8 years, 9 months ago (2012-03-03 08:35:57 UTC) #2
vandebo (ex-Chrome)
8 years, 9 months ago (2012-03-05 17:20:28 UTC) #3
On 2012/03/03 08:35:57, scottmg wrote:
> On 2012/03/03 04:22:56, vandebo wrote:
> 
> Thanks for tracking this down. I guess it broke XP-only it looks like?

Yea, seems to only break XP.

Powered by Google App Engine
This is Rietveld 408576698