Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp

Issue 9572031: Don't be so CRASH happy in the bindings layer. (Closed) Base URL: http://svn.webkit.org/repository/webkit/trunk/Source/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WebCore/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp ('k') | WebCore/dom/ScriptExecutionContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp
===================================================================
--- WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp (revision 109601)
+++ WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp (working copy)
@@ -70,7 +70,8 @@
v8::Handle<v8::Value> observerHandle = toV8(observer);
if (observerHandle.IsEmpty()) {
- CRASH();
+ if (!isScriptControllerTerminating())
+ CRASH();
return true;
}
« no previous file with comments | « WebCore/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp ('k') | WebCore/dom/ScriptExecutionContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698