WebCore/bindings/scripts/CodeGeneratorV8.pm - Issue 9572031: Don't be so CRASH happy in the bindings layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: WebCore/bindings/scripts/CodeGeneratorV8.pm

Issue 9572031: Don't be so CRASH happy in the bindings layer. (Closed) Base URL: http://svn.webkit.org/repository/webkit/trunk/Source/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: WebCore/bindings/scripts/CodeGeneratorV8.pm

===================================================================

--- WebCore/bindings/scripts/CodeGeneratorV8.pm (revision 109601)

+++ WebCore/bindings/scripts/CodeGeneratorV8.pm (working copy)

@@ -2996,7 +2996,8 @@

my $paramName = $param->name;

push(@implContent, " v8::Handle<v8::Value> ${paramName}Handle = " . NativeToJSValue($param, $paramName) . ";\n");

push(@implContent, " if (${paramName}Handle.IsEmpty()) {\n");

- push(@implContent, " CRASH();\n");

+ push(@implContent, " if (!isScriptControllerTerminating())\n");

+ push(@implContent, " CRASH();\n");

push(@implContent, " return true;\n");

push(@implContent, " }\n");

push(@args, " ${paramName}Handle");