Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: WebCore/bindings/generic/ActiveDOMCallback.h

Issue 9572031: Don't be so CRASH happy in the bindings layer. (Closed) Base URL: http://svn.webkit.org/repository/webkit/trunk/Source/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | WebCore/bindings/generic/ActiveDOMCallback.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef ActiveDOMCallback_h 31 #ifndef ActiveDOMCallback_h
32 #define ActiveDOMCallback_h 32 #define ActiveDOMCallback_h
33 33
34 #include "ContextDestructionObserver.h"
34 #include <wtf/OwnPtr.h> 35 #include <wtf/OwnPtr.h>
35 36
36 namespace WebCore { 37 namespace WebCore {
37 38
38 class ActiveDOMObjectCallbackImpl;
39 class ScriptExecutionContext; 39 class ScriptExecutionContext;
40 40
41 // A class that allows callbacks to behave like ActiveDOMObjects, and also 41 // A base class that prevents binding callbacks from executing when
42 // be destroyed on the context thread or any other thread. 42 // active dom objects are stopped or suspended, and is used by the
43 class ActiveDOMCallback { 43 // generated callback v8 bindings code to avoid erroneously CRASH()'ing
44 // after script execution on a worker has been terminated.
45 //
46 // Should only be created, used, and destroyed on the script execution
47 // context thread.
48 class ActiveDOMCallback : public ContextDestructionObserver {
44 public: 49 public:
45 ActiveDOMCallback(ScriptExecutionContext* context); 50 ActiveDOMCallback(ScriptExecutionContext* context);
46 ~ActiveDOMCallback(); 51 virtual ~ActiveDOMCallback();
47 52
48 bool canInvokeCallback() const; 53 bool canInvokeCallback() const;
49 ScriptExecutionContext* scriptExecutionContext() const; 54 bool isScriptControllerTerminating() const;
50
51 private:
52 // The ActiveDOMObject part of the callback.
53 OwnPtr<ActiveDOMObjectCallbackImpl> m_impl;
54 }; 55 };
55 56
56 } // namespace WebCore 57 } // namespace WebCore
57 58
58 #endif // ActiveDOMCallback_h 59 #endif // ActiveDOMCallback_h
OLDNEW
« no previous file with comments | « no previous file | WebCore/bindings/generic/ActiveDOMCallback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698