Issue 9572014: Recfactor core HasElement functionality into ElementsAccessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9572014: Recfactor core HasElement functionality into ElementsAccessors (Closed)

Created:
8 years, 9 months ago by danno

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Recfactor core HasElement functionality into ElementsAccessors Committed: https://code.google.com/p/v8/source/detail?r=10926

Patch Set 1 #

Patch Set 2 : Rename parameter #

Total comments: 2

Patch Set 3 : Review feedback #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -212 lines)			Patch
M	src/elements.h	View		3 chunks	+12 lines, -12 lines	0 comments	Download
M	src/elements.cc	View	1	11 chunks	+57 lines, -39 lines	0 comments	Download
M	src/objects.h	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	1 2	4 chunks	+18 lines, -157 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with one question (see below). These changes are easier than I thought they would ...

8 years, 9 months ago (2012-03-05 10:54:11 UTC) #2

danno

8 years, 9 months ago (2012-03-06 11:02:05 UTC) #3

Landed

http://codereview.chromium.org/9572014/diff/2001/src/objects.cc
File src/objects.cc (left):

http://codereview.chromium.org/9572014/diff/2001/src/objects.cc#oldcode8987
src/objects.cc:8987: if (pt->IsJSProxy()) {
On 2012/03/05 10:54:11, Jakob wrote:
> where did this case go?

Done.

Expand Messages | Collapse Messages