Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 9572009: Ensure consistent result of transcendental functions. (Closed)

Created:
8 years, 9 months ago by Yang
Modified:
8 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Ensure consistent result of transcendental functions. BUG= TEST=regress-transcendental.js Committed: https://code.google.com/p/v8/source/detail?r=10908

Patch Set 1 #

Patch Set 2 : Fix compile errors for arm and mips. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -26 lines) Patch
M src/arm/codegen-arm.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/heap-inl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/codegen-mips.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-transcendental.js View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
This CL: - actually enables inlining of Math.tan in crankshaft - makes sure that we ...
8 years, 9 months ago (2012-03-02 13:24:32 UTC) #1
Sven Panne
8 years, 9 months ago (2012-03-02 14:01:21 UTC) #2
LGTM. Just a remark: We could generate all fast_foo stubs in
V8::InitializeOncePerProcess(), removing the need for a separate mutex. We could
even generate all those stubs (incl. the modulo stub) in a single tiny region.
But OTOH programs might not need those stubs at all. It's a judgement call...

Powered by Google App Engine
This is Rietveld 408576698