Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/browser/renderer_host/resource_dispatcher_host.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clang fix Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_dispatcher_host.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host.cc b/content/browser/renderer_host/resource_dispatcher_host.cc
index 0a6a846685e552609b56750fffefa77eb1a1179e..53af65ba5c0e4ac6c05eb47c0b64cb8d5dfb8829 100644
--- a/content/browser/renderer_host/resource_dispatcher_host.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host.cc
@@ -60,6 +60,7 @@
#include "content/public/browser/resource_dispatcher_host_login_delegate.h"
#include "content/public/browser/resource_throttle.h"
#include "content/public/common/content_switches.h"
+#include "content/public/common/content_url_request_user_data.h"
#include "content/public/common/process_type.h"
#include "content/public/common/url_constants.h"
#include "net/base/auth.h"
@@ -384,6 +385,10 @@ void ResourceDispatcherHost::SetRequestInfo(
net::URLRequest* request,
ResourceDispatcherHostRequestInfo* info) {
request->SetUserData(NULL, info);
+ request->SetUserData(
+ content::ContentURLRequestUserData::kUserDataKey,
+ new content::ContentURLRequestUserData(
+ info->child_id(), info->route_id()));
}
void ResourceDispatcherHost::OnShutdown() {
@@ -1423,36 +1428,6 @@ void ResourceDispatcherHost::OnSSLCertificateError(
SSLManager::OnSSLCertificateError(this, request, ssl_info, is_hsts_host);
}
-bool ResourceDispatcherHost::CanGetCookies(
- const net::URLRequest* request,
- const net::CookieList& cookie_list) const {
- VLOG(1) << "OnGetCookies: " << request->url().spec();
- int render_process_id, render_view_id;
- if (!RenderViewForRequest(request, &render_process_id, &render_view_id))
- return false;
-
- const ResourceDispatcherHostRequestInfo* info = InfoForRequest(request);
-
- return content::GetContentClient()->browser()->AllowGetCookie(
- request->url(), request->first_party_for_cookies(), cookie_list,
- info->context(), render_process_id, render_view_id);
-}
-
-bool ResourceDispatcherHost::CanSetCookie(const net::URLRequest* request,
- const std::string& cookie_line,
- net::CookieOptions* options) const {
- VLOG(1) << "OnSetCookie: " << request->url().spec();
-
- int render_process_id, render_view_id;
- if (!RenderViewForRequest(request, &render_process_id, &render_view_id))
- return false;
-
- const ResourceDispatcherHostRequestInfo* info = InfoForRequest(request);
- return content::GetContentClient()->browser()->AllowSetCookie(
- request->url(), request->first_party_for_cookies(), cookie_line,
- info->context(), render_process_id, render_view_id, options);
-}
-
void ResourceDispatcherHost::OnResponseStarted(net::URLRequest* request) {
VLOG(1) << "OnResponseStarted: " << request->url().spec();
ResourceDispatcherHostRequestInfo* info = InfoForRequest(request);

Powered by Google App Engine
This is Rietveld 408576698