Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clang fix Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_url_fetcher.cc
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.cc b/chrome/service/cloud_print/cloud_print_url_fetcher.cc
index b19a7c26cabc709ef779b4530cc95a12da4140a1..babe7b4edd6245e8e33bcd7fbfd4a7d978f6c397 100644
--- a/chrome/service/cloud_print/cloud_print_url_fetcher.cc
+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.cc
@@ -11,6 +11,7 @@
#include "chrome/service/cloud_print/cloud_print_token_store.h"
#include "chrome/service/net/service_url_request_context.h"
#include "chrome/service/service_process.h"
+#include "content/public/common/content_url_request_user_data.h"
#include "googleurl/src/gurl.h"
#include "net/http/http_status_code.h"
#include "net/url_request/url_request_status.h"
@@ -124,7 +125,10 @@ void CloudPrintURLFetcher::OnURLFetchComplete(
// reached. Try again. Set up the request headers again because the token
// may have changed.
SetupRequestHeaders();
- request_->StartWithRequestContextGetter(GetRequestContextGetter());
+ // TODO(jochen): Do cookie audit.
+ request_->StartWithRequestContextGetterAndUserData(
+ GetRequestContextGetter(),
+ new content::ContentURLRequestUserData());
}
}
}
@@ -142,6 +146,9 @@ void CloudPrintURLFetcher::StartRequestHelper(
additional_headers_ = additional_headers;
request_.reset(content::URLFetcher::Create(url, request_type, this));
request_->SetRequestContext(GetRequestContextGetter());
+ // TODO(jochen): Do cookie audit.
+ request_->SetContentURLRequestUserData(
+ new content::ContentURLRequestUserData());
// Since we implement our own retry logic, disable the retry in URLFetcher.
request_->SetAutomaticallyRetryOn5xx(false);
request_->SetMaxRetries(max_retries);

Powered by Google App Engine
This is Rietveld 408576698