Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2247)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clang fix Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index a22b603d41267c2b40d2f30885bdc14ed65ab588..a48df16ea79880f66dbcc02c119c9f800031b59e 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -44,6 +44,7 @@
#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/content_url_request_user_data.h"
#include "content/public/common/url_fetcher.h"
#include "grit/browser_resources.h"
#include "net/base/escape.h"
@@ -799,6 +800,9 @@ void TranslateManager::FetchLanguageListFromTranslateServer(
1, GURL(kLanguageListFetchURL), content::URLFetcher::GET, this));
language_list_request_pending_->SetRequestContext(
g_browser_process->system_request_context());
+ // TODO(jochen): Do cookie audit.
+ language_list_request_pending_->SetContentURLRequestUserData(
+ new content::ContentURLRequestUserData());
language_list_request_pending_->SetMaxRetries(kMaxRetryLanguageListFetch);
language_list_request_pending_->Start();
}
@@ -816,6 +820,9 @@ void TranslateManager::RequestTranslateScript() {
0, GURL(kTranslateScriptURL), content::URLFetcher::GET, this));
translate_script_request_pending_->SetRequestContext(
g_browser_process->system_request_context());
+ // TODO(jochen): Do cookie audit.
+ translate_script_request_pending_->SetContentURLRequestUserData(
+ new content::ContentURLRequestUserData());
translate_script_request_pending_->SetExtraRequestHeaders(
kTranslateScriptHeader);
translate_script_request_pending_->Start();

Powered by Google App Engine
This is Rietveld 408576698