Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clang fix Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_service.cc
diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc
index d176ee5a2e28c45d2f7b19b40ddad85bb80fe1b5..4026ca6cc46ca5a3f015abc48191b2dbcecfb2b7 100644
--- a/chrome/browser/safe_browsing/client_side_detection_service.cc
+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc
@@ -24,6 +24,7 @@
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_process_host.h"
+#include "content/public/common/content_url_request_user_data.h"
#include "content/public/common/url_fetcher.h"
#include "crypto/sha2.h"
#include "googleurl/src/gurl.h"
@@ -253,6 +254,9 @@ void ClientSideDetectionService::StartFetchModel() {
0 /* ID used for testing */, GURL(kClientModelUrl),
content::URLFetcher::GET, this));
model_fetcher_->SetRequestContext(request_context_getter_.get());
+ // TODO(jochen): Do cookie audit.
+ model_fetcher_->SetContentURLRequestUserData(
+ new content::ContentURLRequestUserData());
model_fetcher_->Start();
}
}
@@ -314,6 +318,9 @@ void ClientSideDetectionService::StartClientReportPhishingRequest(
fetcher->SetLoadFlags(net::LOAD_DISABLE_CACHE);
fetcher->SetRequestContext(request_context_getter_.get());
+ // TODO(jochen): Do cookie audit.
+ fetcher->SetContentURLRequestUserData(
+ new content::ContentURLRequestUserData());
fetcher->SetUploadData("application/octet-stream", request_data);
fetcher->Start();

Powered by Google App Engine
This is Rietveld 408576698