Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

content/public/common/url_request_user_data.cc

Index: content/public/common/url_request_user_data.cc
diff --git a/content/public/common/url_request_user_data.cc b/content/public/common/url_request_user_data.cc
new file mode 100644
index 0000000000000000000000000000000000000000..052b6d024c31df95c7b7788f0a225f6170cca47f
--- /dev/null
+++ b/content/public/common/url_request_user_data.cc
@@ -0,0 +1,19 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/public/common/url_request_user_data.h"

[jam, 2012/03/05 19:11:03]

is this cc file needed at all? we try to avoid cc files in the public dir unless
necessary.

i know for sure the destructor can move to the header without warnings. i think
the constructor can as well because the members are PODs. we can then move the
static to url_fetcher_impl.cc 

[jochen (gone - plz use gerrit), 2012/03/06 18:39:54]

I need the .cc file for the static const, however, it doesn't need to be in
public. What about just moving it to content/common?

+
+namespace content {
+
+URLRequestUserData::URLRequestUserData(int process_id, int routing_id)
+    : process_id(process_id),
+      routing_id(routing_id) {}
+
+URLRequestUserData::~URLRequestUserData() {}
+
+// static
+const void* URLRequestUserData::kUserDataKey =

[cbentzel, 2012/03/05 12:56:12]

Funky - most other cases I've seen use a NULL-terminated-string constant to act
as key, but this will work as well.

Do you actually need the static_cast here? I thought cast-to-void* is allowed
implicitly.

+    static_cast<const void*>(&URLRequestUserData::kUserDataKey);
+
+}  // namespace content