Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Issue 9570064: Fix keyword search erroneously not triggering in two obscure cases: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc (revision 124492)
+++ chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc (working copy)
@@ -724,11 +724,8 @@
// See if the text or selection have changed since OnBeforePossibleChange().
const string16 new_text(GetText());
- text_changed_ = (new_text != text_before_change_);
- if (supports_pre_edit_) {
- text_changed_ =
- text_changed_ || (pre_edit_.size() != pre_edit_size_before_change_);
- }
+ text_changed_ = (new_text != text_before_change_) || (supports_pre_edit_ &&
+ (pre_edit_.size() != pre_edit_size_before_change_));
if (text_changed_)
AdjustTextJustification();
@@ -746,9 +743,9 @@
delete_at_end_pressed_ = false;
const bool something_changed = model_->OnAfterPossibleChange(
- new_text, new_sel.selection_min(), new_sel.selection_max(),
- selection_differs, text_changed_, just_deleted_text,
- !IsImeComposing());
+ text_before_change_, new_text, new_sel.selection_min(),
+ new_sel.selection_max(), selection_differs, text_changed_,
+ just_deleted_text, !IsImeComposing());
// If only selection was changed, we don't need to call |controller_|'s
// OnChanged() method, which is called in TextChanged().
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698