Add a flow class to abstract all the details of minting a token for an app.

Add a flow class to abstract all the details of minting a token for an app.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124841

[Munjal (Google), 2012-03-02 23:20:04]

Add a flow class to combine two steps of generating an oauth token:
- Get access token from refresh token
- Use access token to hit the endpoint ot get a token for another client.

[asargent_no_longer_on_chrome, 2012-03-03 00:09:31]

lgtm

In looking at this CL, it strikes me how similar oauth2_access_token_fetcher.h
and oauth2_mint_token_fetcher.h are. I glanced at the implementations of each
class too and they are pretty similar apart from:

-parameters to create one
-url that gets fetched
-request body format
-name of value we pull out of the JSON response

It would be good to see if we can merge the common parts into one class and then
just specialize the parts above for each use case.

https://chromiumcodereview.appspot.com/9570063/diff/4001/chrome/common/net/ga...
File chrome/common/net/gaia/oauth2_mint_token_flow.h (right):

https://chromiumcodereview.appspot.com/9570063/diff/4001/chrome/common/net/ga...
chrome/common/net/gaia/oauth2_mint_token_flow.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
2012 strikes again! Sneaky bugger

https://chromiumcodereview.appspot.com/9570063/diff/4001/chrome/common/net/ga...
chrome/common/net/gaia/oauth2_mint_token_flow.h:60: // Helper to create an
instnace of access token fetcher.
typo: "instnace"

[Munjal (Google), 2012-03-03 00:48:42]

I agree about combining the two fetchers. I will do that separately.

https://chromiumcodereview.appspot.com/9570063/diff/4001/chrome/common/net/ga...
File chrome/common/net/gaia/oauth2_mint_token_flow.h (right):

https://chromiumcodereview.appspot.com/9570063/diff/4001/chrome/common/net/ga...
chrome/common/net/gaia/oauth2_mint_token_flow.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
On 2012/03/03 00:09:31, Antony Sargent wrote:
> 2012 strikes again! Sneaky bugger

Done.

https://chromiumcodereview.appspot.com/9570063/diff/4001/chrome/common/net/ga...
chrome/common/net/gaia/oauth2_mint_token_flow.h:60: // Helper to create an
instnace of access token fetcher.
On 2012/03/03 00:09:31, Antony Sargent wrote:
> typo: "instnace"

Done.

[commit-bot: I haz the power, 2012-03-03 05:45:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/munjal@chromium.org/9570063/4001

[commit-bot: I haz the power, 2012-03-03 08:38:23]

Change committed as 124841