Issue 9570053: [uber page] Fix ignored first click on 'show advanced settings'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9570053: [uber page] Fix ignored first click on 'show advanced settings'. (Closed)

Created:
8 years, 9 months ago by csilv

Modified:
8 years, 9 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[uber page] Fix ignored first click on 'show advanced settings'. BUG=none TEST=Verify 'show/hide' advanced settings responds to click. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124713

Patch Set 1 #

Total comments: 4

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/options2/browser_options.js	View		2 chunks	+2 lines, -2 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm i noticed another bug with setting the height to a pixel value. When you ...

8 years, 9 months ago (2012-03-02 17:09:27 UTC) #2

csilv

8 years, 9 months ago (2012-03-02 19:29:40 UTC) #3

http://codereview.chromium.org/9570053/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options2/browser_options.js (right):

http://codereview.chromium.org/9570053/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options2/browser_options.js:475:
$('advanced-settings-expander').innerHTML =
On 2012/03/02 17:09:27, Evan Stade wrote:
> should this be textContent?

Done.

http://codereview.chromium.org/9570053/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options2/browser_options.js:485:
$('advanced-settings-expander').innerHTML =
On 2012/03/02 17:09:27, Evan Stade wrote:
> should this be textContent?

Done.

Expand Messages | Collapse Messages