Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: runtime/vm/native_message_handler.cc

Issue 9570051: Revert my last change. Odd test failures that I will investigate tomorrow. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/message_test.cc ('k') | runtime/vm/port_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/native_message_handler.h" 5 #include "vm/native_message_handler.h"
6 6
7 #include "vm/dart_api_message.h" 7 #include "vm/dart_api_message.h"
8 #include "vm/isolate.h" 8 #include "vm/isolate.h"
9 #include "vm/message.h" 9 #include "vm/message.h"
10 #include "vm/snapshot.h" 10 #include "vm/snapshot.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 43
44 static void RunWorker(uword parameter) { 44 static void RunWorker(uword parameter) {
45 NativeMessageHandler* handler = 45 NativeMessageHandler* handler =
46 reinterpret_cast<NativeMessageHandler*>(parameter); 46 reinterpret_cast<NativeMessageHandler*>(parameter);
47 #if defined(DEBUG) 47 #if defined(DEBUG)
48 handler->CheckAccess(); 48 handler->CheckAccess();
49 #endif 49 #endif
50 50
51 while (handler->HasLivePorts()) { 51 while (handler->HasLivePorts()) {
52 Message* message = handler->Dequeue(0); 52 Message* message = handler->queue()->Dequeue(0);
53 if (message != NULL) { 53 if (message != NULL) {
54 if (message->priority() >= Message::kOOBPriority) { 54 if (message->priority() >= Message::kOOBPriority) {
55 // TODO(turnidge): Out of band messages will not go through 55 // TODO(turnidge): Out of band messages will not go through
56 // the regular message handler. Instead they will be 56 // the regular message handler. Instead they will be
57 // dispatched to special vm code. Implement. 57 // dispatched to special vm code. Implement.
58 UNIMPLEMENTED(); 58 UNIMPLEMENTED();
59 } 59 }
60 // Enter a native scope for handling the message. This will create a 60 // Enter a native scope for handling the message. This will create a
61 // zone for allocating the objects for decoding the message. 61 // zone for allocating the objects for decoding the message.
62 ApiNativeScope scope; 62 ApiNativeScope scope;
(...skipping 15 matching lines...) Expand all
78 78
79 void NativeMessageHandler::StartWorker() { 79 void NativeMessageHandler::StartWorker() {
80 int result = Thread::Start(RunWorker, reinterpret_cast<uword>(this)); 80 int result = Thread::Start(RunWorker, reinterpret_cast<uword>(this));
81 if (result != 0) { 81 if (result != 0) {
82 FATAL1("Failed to start native message handler worker thread %d", result); 82 FATAL1("Failed to start native message handler worker thread %d", result);
83 } 83 }
84 } 84 }
85 85
86 86
87 } // namespace dart 87 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/message_test.cc ('k') | runtime/vm/port_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698