Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9570031: This adds some more attributes to the GData files. (Closed)

Created:
8 years, 9 months ago by Greg Spencer (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
zel, kuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

This adds some more attributes to the GData files. Added thumbnail URL, edit URL, and cache attributes. BUG=chromium-os:27030 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124712

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed swapped fields #

Patch Set 3 : Upload after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system.h View 1 2 3 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 2 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Greg Spencer (Chromium)
This is just the GDataFile parts of http://codereview.chromium.org/9545006/
8 years, 9 months ago (2012-03-01 21:58:11 UTC) #1
kuan
On 2012/03/01 21:58:11, Greg Spencer (Chromium) wrote: > This is just the GDataFile parts of ...
8 years, 9 months ago (2012-03-01 22:18:59 UTC) #2
zel
http://codereview.chromium.org/9570031/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.h File chrome/browser/chromeos/gdata/gdata_file_system.h (right): http://codereview.chromium.org/9570031/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.h#newcode87 chrome/browser/chromeos/gdata/gdata_file_system.h:87: const GURL& thumbnail_url() const { return edit_url_; } thumbnail_url_ ...
8 years, 9 months ago (2012-03-01 22:21:16 UTC) #3
Greg Spencer (Chromium)
http://codereview.chromium.org/9570031/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.h File chrome/browser/chromeos/gdata/gdata_file_system.h (right): http://codereview.chromium.org/9570031/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.h#newcode87 chrome/browser/chromeos/gdata/gdata_file_system.h:87: const GURL& thumbnail_url() const { return edit_url_; } On ...
8 years, 9 months ago (2012-03-01 22:48:28 UTC) #4
zel
lgtm
8 years, 9 months ago (2012-03-01 22:53:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/9570031/6001
8 years, 9 months ago (2012-03-01 23:12:13 UTC) #6
commit-bot: I haz the power
Try job failure for 9570031-6001 (retry) on win_rel for step "ui_tests". It's a second try, ...
8 years, 9 months ago (2012-03-02 02:39:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/9570031/6001
8 years, 9 months ago (2012-03-02 03:06:33 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 18:37:09 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698