Fix for "removing tasks can change row selection" bug.

chrome/browser/resources/task_manager/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @constructor */
 function TaskManager() { }
 
 cr.addSingletonGetter(TaskManager);
 
 var localStrings = new LocalStrings();
@@ skipping 524 matching lines @@
     if (!dm || !sm) return;
 
     this.table_.list.startBatchUpdates();
     sm.beginChange();
 
     var type = task.type;
     var start = task.start;
     var length = task.length;
     var tasks = task.tasks;
 
-    // We have to store the selected indexes and restore them after
+    // We have to store the selected pids and restore them after
     // splice(), because it might replace some items but the replaced
     // items would lose the selection.
     var oldSelectedIndexes = sm.selectedIndexes;
 
+    // Create map of selected PIDs.
+    var oldSelectedPids = {};

[flackr, 2012/03/01 21:45:06]

You can probably just call this selectedPids since (killed processes aside)
these will be consistent before and after.

[Kevin Greer, 2012/03/01 22:13:44]

Done.

+    for (var i = 0; i < oldSelectedIndexes.length; i++) {
+      var item = dm.item(oldSelectedIndexes[i]);
+      if (item) oldSelectedPids[item['processId'][0]] = true;
+    }
+
     var args = tasks.slice();
     args.unshift(start, dm.length);
     dm.splice.apply(dm, args);
 
-    sm.selectedIndexes = oldSelectedIndexes.filter(function(index) {
-      return index < dm.length;
-    });
+    // Create new array of selected indices from map of old PIDs.

[flackr, 2012/03/01 21:45:06]

nit: s/indices/indexes since that's the property name.

[Kevin Greer, 2012/03/01 22:13:44]

Done.

+    var newSelectedIndexes = [];
+    for (var i = 0; i < dm.length; i++) {
+      if (oldSelectedPids[dm.item(i)['processId'][0]])
+        newSelectedIndexes.push(i);
+    }
+
+    sm.selectedIndexes = newSelectedIndexes;
 
     var pids = [];
     for (var i = 0; i < dm.length; i++) {
       pids.push(dm.item(i)['processId'][0]);
     }
 
     // Sweeps unused caches, which elements no longer exist on the list.
     for (var pid in this.elementsCache_) {
       if (pids.indexOf(pid) == -1)
         delete this.elementsCache_[pid];
@@ skipping 118 matching lines @@
   var params = parseQueryParams(window.location);
   var opt = {};
   opt['isShowTitle'] = params.showtitle;
   opt['isBackgroundMode'] = params.background;
   opt['isShowCloseButton'] = params.showclose;
   taskmanager.initialize(document.body, opt);
 }
 
 document.addEventListener('DOMContentLoaded', init);
 document.addEventListener('Close', taskmanager.onClose.bind(taskmanager));