Fix for "removing tasks can change row selection" bug.

Fix for "removing tasks can change row selection" bug.


BUG=115171
TEST=See repro steps in bug report.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124945

[Kevin Greer, 2012-03-01 21:31:24]

Please review.

[flackr, 2012-03-01 21:45:06]

LGTM.

Can you change TODO line to say "See repro steps in bug report." or something to
that effect?

https://chromiumcodereview.appspot.com/9570028/diff/1/chrome/browser/resource...
File chrome/browser/resources/task_manager/main.js (right):

https://chromiumcodereview.appspot.com/9570028/diff/1/chrome/browser/resource...
chrome/browser/resources/task_manager/main.js:551: var oldSelectedPids = {};
You can probably just call this selectedPids since (killed processes aside)
these will be consistent before and after.

https://chromiumcodereview.appspot.com/9570028/diff/1/chrome/browser/resource...
chrome/browser/resources/task_manager/main.js:561: // Create new array of
selected indices from map of old PIDs.
nit: s/indices/indexes since that's the property name.

[Kevin Greer, 2012-03-01 22:13:44]

Addressed flackr's review comments.

https://chromiumcodereview.appspot.com/9570028/diff/1/chrome/browser/resource...
File chrome/browser/resources/task_manager/main.js (right):

https://chromiumcodereview.appspot.com/9570028/diff/1/chrome/browser/resource...
chrome/browser/resources/task_manager/main.js:551: var oldSelectedPids = {};
On 2012/03/01 21:45:06, flackr wrote:
> You can probably just call this selectedPids since (killed processes aside)
> these will be consistent before and after.

Done.

https://chromiumcodereview.appspot.com/9570028/diff/1/chrome/browser/resource...
chrome/browser/resources/task_manager/main.js:561: // Create new array of
selected indices from map of old PIDs.
On 2012/03/01 21:45:06, flackr wrote:
> nit: s/indices/indexes since that's the property name.

Done.

[Kevin Greer, 2012-03-01 22:15:39]

Please review.

[yoshiki, 2012-03-02 03:08:17]

LGTM

[James Hawkins, 2012-03-02 22:40:02]

lgtm

[commit-bot: I haz the power, 2012-03-05 14:04:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kgr@chromium.org/9570028/3001

[commit-bot: I haz the power, 2012-03-05 15:51:10]

Change committed as 124945